Fixed Visual bug with hovering links and scrolling - Githubissues

xtermjs / xterm.js

A terminal for the web

https://xtermjs.org/

MIT License

16.99k stars 1.59k forks source link

Fixed Visual bug with hovering links and scrolling #5029

Open Skinbow opened 2 months ago

Skinbow commented 2 months ago

Hello.

I managed to remove a visual bug with link hover underlines staying after scrolling upwards, as the link would not be refreshed when it went off-screen. I used the assumption from the previous line (from the one where I made the change) where e.start is 0 if a scroll occurred.

I first encountered this bug on vscode. It normally fixes https://github.com/microsoft/vscode/issues/207956 I am unsure whether it fixes https://github.com/xtermjs/xterm.js/issues/4661 as I do not know how to check the change directly on vscode.

Thank you for your time and consideration.

Skinbow commented 1 week ago

Hello. On my first send I seem to have encounetered a linter problem that I have since fixed. Could you accept my pull request once more please? Thank you in advance.