Speed up insertion and deletion of values in SortedList by batching and deferring to idle task

xtermjs / xterm.js

A terminal for the web

https://xtermjs.org/

MIT License

17.52k stars 1.62k forks source link

Speed up insertion and deletion of values in SortedList by batching and deferring to idle task #5038

Closed Tyriar closed 5 months ago

Tyriar commented 5 months ago

Fixes #4911

Test setup:

10000 scrollback filled
Decoration stress test button
~10000 * 20 = ~200,000 decorations

Before:

Insert ~4s Delete ~4s

After:

Insert ~330ms Delete ~93ms

There's still a decent amount of GC happening on insert, but a lot of it has to happen due to the variables being used in callbacks. It's reasonable when you consider it's 200000 decorations.