search

xtermjs / xterm.js

A terminal for the web
https://xtermjs.org/
MIT License
17.42k stars 1.62k forks source link

Make addon peer dependencies friendly with npm #5135

Closed Tyriar closed 1 week ago

Tyriar commented 3 weeks ago

Right now we have stable xterm.js declared as a peer dependency of the beta addons. This ends up causing issue with npm https://github.com/microsoft/vscode/issues/196795#issuecomment-2298982911. To fix this we probably need to update the peer dependency when we update the version of the addons on publish

jerch commented 3 weeks ago

Glad to see a move back to npm - it is not only the official package installer, it also got much better lately, but more importantly we encountered issues with yarn in other projects, where its package cache might apply the wrong package version (and we had to switch back to npm, mind you - those issues are all around ESM support in various 3rd party packages, grrr).

Tyriar commented 3 weeks ago

npm has been plenty fast for a long time and I think we also switched before package-lock.json was a thing.