This was a very long standing bug that was hard to nail down a repro case. Turns out this was because at some point the current link can get cleared and re-evaluated, I think because of a different fix we made. That caused the object check to fail. So the fix there is to check link equality, not js object equality.
Additionally I found we don't dispose of old linkifiers when open is called multiple times.
This was a very long standing bug that was hard to nail down a repro case. Turns out this was because at some point the current link can get cleared and re-evaluated, I think because of a different fix we made. That caused the object check to fail. So the fix there is to check link equality, not js object equality.
Additionally I found we don't dispose of old linkifiers when open is called multiple times.
See microsoft/vscode#230010