.gitignore for .antlr-generator-3.2.0.jar

xtext / maven-xtext-example

An Xtext language and example usage of it built with Maven

61 stars 33 forks source link

.gitignore for .antlr-generator-3.2.0.jar #15

Closed vorburger closed 10 years ago

vorburger commented 10 years ago

One would typically probably want yourlang/.antlr-generator-3.2.0.jar to be on .gitignore?

vorburger commented 10 years ago

I've just stumbled across commit https://github.com/svenefftinge/maven-xtext-example/commit/35226c31e4a319447915b0f3c1d7e11adefde9e7, where @dhuebner removed a my.mavenized.herolanguage.releng/.antlr-generator-3.2.0.jar, confirming that this shouldn't be in Git?

Not sure why there it was in herolanguage.releng (while this is a .gitignore for herolanguage/) - if it can be in both, there should be a .gitignore in releng as well? Or this one should rather be in the root...

dhuebner commented 10 years ago

Antlr generator will be pulled as transitive dependency with org.eclipse.xtext.xtext, so we do not need this jar any more. This jar should not appear during the maven build. Why setting it to gitignore?

svenefftinge commented 10 years ago

as per dennis' comment