search

xtext / maven-xtext-example

An Xtext language and example usage of it built with Maven
61 stars 33 forks source link

Fixed file encoding, line endings and package naming plus new parent #42

Closed michael-schnell closed 7 years ago

michael-schnell commented 7 years ago

Hi,

I'm currently in the process of updating the emt-xtext-archetype based on your maven-xtext-example.

During the process I fixed some inconsistiencies:

For creating an achetype it's unfortunately necessary to have a "pom.xml" in the root folder. Therefore I created a new parent pom that contains only the modules in the root folder. It's not the parent pom of the other modules (that's still "releng").

Would be nice if you can take over the changes.

Cheers, Michael

svenefftinge commented 7 years ago

Wouldn't it then make sense to move the releng pom up, so that we only have one parent pom?

michael-schnell commented 7 years ago

Thought about it, but wasn't sure how flexible you are with restructuring ;-) I'll prepare that change and update the pull request.

Another question: What do you think about renaming the "my.mavenized.herolanguage" folder? All other modules follow the pattern "my.mavenized.herolanguage.MODULE", but the language folder does not. A good name would be "my.mavenized.herolanguage.dsl" or "my.mavenized.herolanguage.model"? Should I implement that change as well?

michael-schnell commented 7 years ago

There is now only one parent POM and a link to the Maven Archetype is included.

Notified the owner of this repor via https://www.eclipse.org/forums/index.php/m/1768722/#msg_1768722

svenefftinge commented 7 years ago

thanks