search

xtext / maven-xtext-example

An Xtext language and example usage of it built with Maven
61 stars 33 forks source link

remove unnecessary P2 repositories #85

Closed asheiduk closed 2 years ago

asheiduk commented 2 years ago

Since everything is contained in the Eclipse Release Train the additional URLs are not required.

cdietrich commented 2 years ago

thx @asheiduk

LorenzoBettini commented 2 years ago

However, this will prevent testing the example with specific versions of Xtext and other versions of Eclipse. Is that what we want?

By the way, the Xtext p2 repository was based on the property for the Xtext version, so changing the property was enough to keep things consistent. Maybe it was the case to have a property for MWE as well.

Unfortunately, I came late, but I think it's wrong to remove those two p2 repos...

asheiduk commented 2 years ago

I came to this repo via Continuous Integration (with Maven) -- the official Xtext documentation. So I gather the main purpose is to show the people a proper and minimal setup. Otherwise these URLs get copy-pasted everywhere. In my case it affects whether or not to mirror those repos due to corporate firewall.

LorenzoBettini commented 2 years ago

I see, but that contrasts with the standard Eclipse plugin projects created by the Xtext wizard, where Xtext (and MWE) are "taken" from their p2 repositories. However, I leave the decision to @cdietrich.

I'm not sure I understand your problem with mirroring though: you still need to mirror the same stuff

asheiduk commented 2 years ago

But I need to ask the department only for one mirror, not for three.

LorenzoBettini commented 2 years ago

I see, but I don't see that as a valid reason to change the example ;)

cdietrich commented 2 years ago

the example is bogus anyway. clean solution would be to use a target platform when we will leave the simrel we can split again.

LorenzoBettini commented 2 years ago

@cdietrich I agree 👍