search

xtext / xtext-reference-projects

A collection of Xtext sample projects for build integration tests
Eclipse Public License 1.0
7 stars 6 forks source link

Cd xtext issue 2849 #390

Closed LorenzoBettini closed 10 months ago

LorenzoBettini commented 10 months ago

Archive screenshots in case of failure and increased SWTBot timeout

LorenzoBettini commented 10 months ago

@cdietrich I added the changes on top of your branch concerning only the flaky job and the flaky SWTBot tests. GitHub Actions don't start on my fork, so I'll have to check it in this PR

LorenzoBettini commented 10 months ago

The failed build is not related to this PR

LorenzoBettini commented 10 months ago

@cdietrich my timeout property does not work because in these projects you use SWTBot API with explicit fixed timeouts... I can fix that at least for deleteAllProjects, but in general it's an antipattern to use fixed timeouts when calling SWTBot API, at least for my knowledge

cdietrich commented 10 months ago

@LorenzoBettini can you please rebase on master

LorenzoBettini commented 10 months ago

@cdietrich so my PR should be against master, not against your branch?

cdietrich commented 10 months ago

2nd question: dont you have write access to this repo?

LorenzoBettini commented 10 months ago

No I don't

cdietrich commented 10 months ago

@LorenzoBettini now you should

cdietrich commented 10 months ago

@LorenzoBettini yes PR against master

LorenzoBettini commented 10 months ago

Replaced by #391 https://github.com/xtext/xtext-reference-projects/pull/391