search

xtf-cz / xtf

MIT License
12 stars 55 forks source link

Allow testsuite to pull images from secured repo e.g. `registry.redhat.io` #283

Closed mchoma closed 5 years ago

mchoma commented 5 years ago

This seemed to be in https://github.com/xtf-cz/xtf/pull/153/files however was removed by https://github.com/xtf-cz/xtf/commit/dafcd8def33d039256e88e431befac4acb412fa5 .

dsimansk commented 5 years ago

@maschmid @Crumby Would be a ProjectCreator listener a good place to migrate the former code that created registry secret and linked it to SAs? Wdyt? Or a separate is better alternative?

AFAIK @rvais is currently looking into providing a solution based on the previous impl.

mnovak1 commented 5 years ago

hi guys, did you manage to deal with it ro it's still unresolved?

rvais commented 5 years ago

I have working implementation in ProjectCreator class. However I still wait for the reply in this thread whether or not I should create PR.

Crumby commented 5 years ago

@dsimansk @rvais Yes, ProjectCreator is a good place where this feature should be present. But it should also work in a reasonable way for BuildManager

rvais commented 5 years ago

I will put the code to BuildManager as well and create the PR ...

Crumby commented 5 years ago

Is this still needed? Pulling from secured repositories works out of the box with OpenShift4.

mchoma commented 5 years ago

@Crumby how do you mean? How would you make xtf to work with image from [1]?

Anyway, we still test on OCP 3.11 and will for a long.

[1] https://access.redhat.com/containers/?tab=images&get-method=red-hat-login#/registry.access.redhat.com/jboss-eap-7-tech-preview/eap-cd-openshift-rhel8

Crumby commented 5 years ago

@mchoma Every OpenShift 4 requires pull secret passed during installation. That pull secret is than used for downloading images from secured repository.

mchoma commented 5 years ago

@Crumby please could you elaborate, which param exactly is in charge?