search

xtf-cz / xtf

MIT License
12 stars 54 forks source link

ImageContent should contains both JDK8 and JDK11 default utilities array #445

Open fmongiar opened 3 years ago

fmongiar commented 3 years ago

Checking https://github.com/xtf-cz/xtf/blob/master/test-helpers/src/main/java/cz/xtf/testhelpers/image/ImageContent.java#L28-L32 looks like this array is specific for JDK8. Some of those utilities were deprecated on JDK11

I suggest to add another specific jdk11 variable, as i.e. private static final String[] DEFAULT_JAVA11_UTILITIES = new String[]{"jaotc", "jar", "jarsigner", "java", "javac", "javadoc", "javap", "jcmd", "jconsole", "jdb", "jdeprscan", "jdeps", "jfr", "jhsdb", "jimage", "jinfo", "jjs", "jlink", "jmap", "jmod", "jps", "jrunscript", "jshell", "jstack", "jstat", "jstatd", "keytool", "pack200", "rmic", "rmid", "rmiregistry", "serialver", "unpack200"};

sefroberg commented 2 years ago

I would like to add to this, this call fails on OpenJDK 17. @mnovak1 I can work with you to see how we want to address this.

mnovak1 commented 2 years ago

Thanks guys for spotting this. Having different list for each JDK makes sense to me. So +1 for proposed solution.

sefroberg commented 2 years ago

I can start looking at this in the next couple days once I finish QA work on the OpenJDK 17 containers.