xtf-cz / xtf

MIT License
12 stars 55 forks source link

0.29 fix smongiar #526

Closed smongiar closed 1 year ago

smongiar commented 1 year ago

Please make sure your PR meets the following requirements:

smongiar commented 1 year ago

Hi, @mnovak1 It seems that connection through kubeconfig doesn't work when we use cerficates and private keys.

One example is provided by:

users:
- name: admin/cds149rd042m87juef2g
  user:
    client-certificate: admin.pem
    client-key: admin-key.pem

in the kubeconfig file

XTF framework actually doesn't allow connections with those key/certificate auth method

smongiar commented 1 year ago

two more comments. Sorry I didn't notice before cry .

CI failures are due to #531 ... please rebase

rebased with the upstream master branch

simkam commented 1 year ago

@smongiar did you push it?

smongiar commented 1 year ago

@smongiar did you push it?

I'm sorry, try again

mnovak1 commented 1 year ago

@smongiar Could you fix the formatting, please? (mvn clean install should do the jobs)

Otherwise LGTM.

smongiar commented 1 year ago

@smongiar Could you fix the formatting, please? (mvn clean install should do the jobs)

Otherwise LGTM.

It should be ok, now

mnovak1 commented 1 year ago

Thanks, merging.

mnovak1 commented 1 year ago

And thanks for the fix! :-)