Fixing BuildManager in order not to create a system:image-puller role for the authenticated users when the master and build namespaces are set to the same value

xtf-cz / xtf

MIT License

12 stars 55 forks source link

Fixing BuildManager in order not to create a system:image-puller role for the authenticated users when the master and build namespaces are set to the same value #537

Closed fabiobrz closed 1 year ago

fabiobrz commented 1 year ago

Fix #536

Tests passed locally.

Please make sure your PR meets the following requirements:

[x] Pull Request contains a description of the changes
[x] Pull Request does not include fixes for multiple issues/topics
[x] Code is formatted, imports ordered, code compiles and tests are passing
[x] Code is self-descriptive and/or documented

fabiobrz commented 1 year ago

LGTM, however we'll need some comparing CI runs with same and different namespaces.

Thanks @mnovak1 - I'll try to collect and share some link to upstream runs in here.

mnovak1 commented 1 year ago

@fabiobrz do we have a passing ci run?

fabiobrz commented 1 year ago

@fabiobrz do we have a passing ci run?

HI @mnovak1 - I released a XTF snapshot containing the fix, and submitted a couple of Intersmash PRs to check it, one uses the same name for both the namespaces [1], and one is changing the one for the build namespace [2]. Let me know whether anything else is needed.

[1] https://github.com/Intersmash/intersmash/pull/44

[2] https://github.com/Intersmash/intersmash/pull/43