xtf-cz / xtf

MIT License
12 stars 55 forks source link

Adding a validation method to XTFConfig to check that build and master namespace don't collide #538

Closed fabiobrz closed 1 year ago

fabiobrz commented 1 year ago

Adding a validation method to XTFConfig, which is called by a static block in order to check that build and master namespace don't collide since this might cause leftover resources to be found by OpenShift::clean()

Fix #536 - alternative to #537

Please make sure your PR meets the following requirements:

simkam commented 1 year ago

I'm not sure whether we should only print a warning. I guess in some cases it might work without issues even when namespace is the same.

mnovak1 commented 1 year ago

@fabiobrz AFACT we allow to set build namespace to master namespace. For example we use it for CVP testing. Thus we'll need to solve all issues instead.

fabiobrz commented 1 year ago

Thanks @simkam, indeed it would work in some cases, while it would not in others, as the one I described in the PR description and here

Thanks @mnovak1 - I'll put this one back to draft, then.

mnovak1 commented 1 year ago

@fabiobrz I'll close this PR as we'll need to resolve issues with the same build and master namespaces instead of trying to avoid it.