search

xtf-cz / xtf

MIT License
12 stars 55 forks source link

Removed HELM_KUBEASUSER from Helm binary + changed rvelc plugin versions #540

Closed spriadka closed 1 year ago

spriadka commented 1 year ago

I have found out that combining HELM_KUBEASUSER and KUBETOKEN does not work well with masterBinary. Removing HELM_KUBEASUSER seems to solve the issue. In addition to this change, I've introduced changes needed to compile the project on Maven 3.9.1 with JDK 8 & 11.

simkam commented 1 year ago

Please split this into multiple commits, maybe PRs.

  1. HELM_KUBEASUSER removal
  2. build changes
  3. formatting changes
spriadka commented 1 year ago

@simkam I've split the changes into https://github.com/xtf-cz/xtf/pull/542 and https://github.com/xtf-cz/xtf/pull/543. Should I close this one then?

mnovak1 commented 1 year ago

Yes, closing this one.