Maven 3.9+ formatter plugin change

xtf-cz / xtf

MIT License

12 stars 55 forks source link

Maven 3.9+ formatter plugin change #543

Closed spriadka closed 1 year ago

spriadka commented 1 year ago

Changes needed to compile the project on Maven 3.9+ with JDK8 & 11.

Please make sure your PR meets the following requirements:

[x] Pull Request contains a description of the changes
[x] Pull Request does not include fixes for multiple issues/topics
[x] Code is formatted, imports ordered, code compiles and tests are passing
[x] Code is self-descriptive and/or documented

mnovak1 commented 1 year ago

@spriadka do you have more info to this one? afaict there should be formatter.xml based on which all is formatted and no changes should occur.

mnovak1 commented 1 year ago

@spriadka I did some tries and the only needed change is to the impsort plugin to add:

<dependencies>
                    <dependency>
                        <groupId>org.codehaus.plexus</groupId>
                        <artifactId>plexus-utils</artifactId>
                        <version>3.5.1</version>
                    </dependency>
                </dependencies>

however no other code changes are needed.

mnovak1 commented 1 year ago

@spriadka I'll replace this PR by https://github.com/xtf-cz/xtf/pull/544 . I don't see any format changes needed as you have and actually I get opposite format changes on this branch.

spriadka commented 1 year ago

okay @mnovak1 , I'll close this one then