xtf-cz / xtf

MIT License
12 stars 55 forks source link

Fix configMapKeyRef: name and key are inverted #546

Closed tommaso-borgato closed 1 year ago

tommaso-borgato commented 1 year ago

This MR fixed the DeploymentConfig produced by ContainerBuilder: At present key and name are inverted:

        - name: POSTGRESQL_ADMIN_PASSWORD
          valueFrom:
            configMapKeyRef:
              name: postgresql-admin-password
              key: postgresql
        - name: POSTGRESQL_PASSWORD
          valueFrom:
            configMapKeyRef:
              name: postgresql-password
              key: postgresql
        - name: POSTGRESQL_USER
          valueFrom:
            configMapKeyRef:
              name: postgresql-user
              key: postgresql

with this MR, the correct output is

        - name: POSTGRESQL_ADMIN_PASSWORD
          valueFrom:
            configMapKeyRef:
              name: postgresql
              key: postgresql-admin-password
        - name: POSTGRESQL_PASSWORD
          valueFrom:
            configMapKeyRef:
              name: postgresql
              key: postgresql-password
        - name: POSTGRESQL_USER
          valueFrom:
            configMapKeyRef:
              name: postgresql
              key: postgresql-user

Please make sure your PR meets the following requirements:

mnovak1 commented 1 year ago

@tommaso-borgato thanks for the fix.