search

xthexder / go-jack

Go bindings for Jack Audio Connection Kit
MIT License
75 stars 21 forks source link

Strerror & GetMidiEvents #2

Closed esqilin closed 8 years ago

esqilin commented 8 years ago

This is my first pull request on github; after reading the guidelines I realize that I should have created one or two new branches.

I created an extra file with function Strerror for translating JACK status values into Go errors. Completely unrelated, the second commit adds the function GetMidiEvents which returns a slice of MidiData pointers. Maybe it is too high level, maybe it should come in a separate subpackage because it necessarily imports jack/midiport.h.

Thanks for the implementation, I also wrote a wrapper and realized that it became way to high level so I switched my projects to your go-jack.

xthexder commented 8 years ago

This looks pretty good, though if we add midi support, it would be nice to have full support rather than just input/read only.

If you'd like you could put something together for midi writes, or I could take a look at it. I haven't really used Jack with midi before so it could be interesting.

esqilin commented 8 years ago

Cool, I'll add full support and an example. Easter Holidays are over though and I have three excursions coming up so I won't be able to do it within the next days. Thanks for looking at it!

On 2016-04-04 22:23, Jacob Wirth wrote:

This looks pretty good, though if we add midi support, it would be nice to have full support rather than just input/read only.

If you'd like you could put something together for midi writes, or I could take a look at it. I haven't really used Jack with midi before so it could be interesting.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/xthexder/go-jack/pull/2#issuecomment-205478585

esqilin commented 8 years ago

Done. Maybe example/Makefile needs to be adjusted.

xthexder commented 8 years ago

Just the one thing, but other than that this looks good :+1: I'll give it a try tonight and merge it when I'm home from work.

sstark commented 8 years ago

Hello, any news if this is going to be merged? I am looking for an alternative to portmidi and jack looks promising. In my project I am only writing midi out. Just it looks to me as if jack will take quite some time to grasp, and before I dive into it I'd like to know if I will be able to use it from go at all. Thank you anyway for making these bindings!

xthexder commented 8 years ago

Sorry about this, this kind of got buried under other work I've been doing, this looks good enough to merge, though I haven't been able to test it myself yet.