search

xtian / node-armory

A simple node.js wrapper around Blizzard's REST API for World of Warcraft.
MIT License
24 stars 8 forks source link

When doing a basic characterAchievements call, getting 404 from armory due to /? on end of url #4

Closed kimptoc closed 11 years ago

kimptoc commented 11 years ago

I have patched my version to only add the /? when there are query options.

Need to re-run the tests, but I guess they worked as there was always parameters present.

Although, just noticed the Battlegroups call requires it, at least the spec says so...

Battlegroups
The battlegroups data API provides the list of battlegroups for this region. Please note the trailing / on this request url.
URL = Host + "/api/wow/data/battlegroups/"
xtian commented 11 years ago

Haha yeah, Blizzard is kind of silly about trailing slash significance. I'll fix this.

kimptoc commented 11 years ago

Thanks :)

I saw on the battle.net forums that its down as a "feature/bug" too about their trailing slashes...

xtian commented 11 years ago

Fixed by ff1ecf7549b49696e9d91373d7c7b96ddbec474e.

kimptoc commented 11 years ago

Thanks :)