xtiankisutsa / MARA_Framework

MARA is a Mobile Application Reverse engineering and Analysis Framework. It is a toolkit that puts together commonly used mobile application reverse engineering and analysis tools to assist in testing mobile applications against the OWASP mobile security threats.
http://www.shadowinfosec.io
GNU Lesser General Public License v3.0
622 stars 174 forks source link

Script can't be called from everywhere #14

Open noraj opened 5 years ago

noraj commented 5 years ago

In mara.sh an maybe in other scripts, a lot of cd and ../../ are used referring from the root of the project ignoring where the script was called from, despite of being ugly, this force the user to change his current directory to the root directory of mara project. So the script can't be launched from everywhere else.

There is an article The Right Way to Get the Directory of a bash Script which seems to have a better approach for calling resources. It would be great to apply that solution.

xtiankisutsa commented 5 years ago

Thank you for this suggestion and the reference article. I agree with your sentiments. I'll look into this solution.