search

xtiankisutsa / MARA_Framework

MARA is a Mobile Application Reverse engineering and Analysis Framework. It is a toolkit that puts together commonly used mobile application reverse engineering and analysis tools to assist in testing mobile applications against the OWASP mobile security threats.
http://www.shadowinfosec.io
GNU Lesser General Public License v3.0
630 stars 175 forks source link

Shellcheck #19

Closed 0xmachos closed 5 years ago

0xmachos commented 5 years ago

You might want to run all the shell/bash scripts through shellcheck. It's a shell script static analysis tool.

Running them through shellcheck via CI (I use Travis) is pretty straightforward. I already have a script, test.sh, that will find all shell/ bash files and run shellcheck on them. Paied with my Travis config, .travis.yml which executes test.sh in the CI instance.

shellcheck will help catch a lot of issues. We can use its warnings as a basis for cleaning up some of scripts.

0xmachos commented 5 years ago

I've created the mara-cleanup branch on my fork to cleanup mara.sh based on shellcheck's errors/warnings.

I'm making some other changes outside of shellcheck's remit so we might want to open another issue to discuss cleaning up mara.sh.

xtiankisutsa commented 5 years ago

This is a pretty neat recommendation. Much appreciated. I'll open a new issue.