search

xtoolbox / TeenyUSB

Lightweight USB device and host stack for STM32 and other MCUs. Ready for USB 3.0 device.
http://www.tusb.org
MIT License
571 stars 178 forks source link

STM32f407_evk Board Config Issues #3

Open Ryzee119 opened 4 years ago

Ryzee119 commented 4 years ago

Hello, great project, it is working very well for me. I did notice these small issues when working with the STM32F40 that may be worth looking at:

Confusing comment

https://github.com/xtoolbox/TeenyUSB/blob/303431c66cc6f31935d090c5269550f31d49a351/demo/boards/stm32f407_evk/board.c#L55-L64

This comment does not reflect the actual pin numbers. Should be UART3 and PC11 and PC10

HOST_PORT_POWER_ON_FS should be active low?

https://github.com/xtoolbox/TeenyUSB/blob/303431c66cc6f31935d090c5269550f31d49a351/demo/boards/stm32f407_evk/board_config.h#L115-L121

Refer user manual page 30/34. I had to change this section of code to enable VBUS at the USB connector.

Thank you! Regards Ryan

xtoolbox commented 4 years ago

My 407 Evk board is this one, Waveshare EVK407I. The power switch use active low logic.

Thanks

Ryzee119 commented 4 years ago

Thank you, yes looks correct to that board. Nice work.