search

xtrasmal / TacticianBundle

Symfony2 Bundle for the Tactician library -DEPRECATED / MOVED to
https://github.com/thephpleague/tactician-bundle
5 stars 2 forks source link

CommandHandler Middleware Validation #21

Closed rdohms closed 9 years ago

rdohms commented 9 years ago

Added extra validation to the Configuration Object to ensure that the command_handler middleware is the last active middleware, if it is present.

In case this middleware is not used, this validation is skipped.

Closes #12.

rtuin commented 9 years ago

I like it! +1 from me

rtuin commented 9 years ago

If we can get the tests to run properly... They failed on my pr too I think. @xtrasmal maybe you can take a look?

rosstuck commented 9 years ago

:+1:

rdohms commented 9 years ago

So, where are we with this? Can someone merge it in, its my policy to never merge my own PRs.

rtuin commented 9 years ago

I'll press the button then. It works fine :+1: