search

xtream1101 / humblebundle-downloader

Download you Humble Bundle Library
MIT License
543 stars 63 forks source link

Humble Trove URL returning HTTP 400 #28

Closed Jimmyson closed 4 years ago

Jimmyson commented 4 years ago

In an effort to get the latest Trove games from my subscription, the Trove URL has been updated to throw 400 errors without the full parameters.

https://github.com/xtream1101/humblebundle-downloader/blob/8561180f3f5ead0be555cd1d4c204b53b27c97bd/humblebundle_downloader/download_library.py#L166

The URL now needs the parameters "property" and "direction".

Example

https://www.humblebundle.com/api/v1/trove/chunk?property=popularity&direction=desc&index=0
bradgy commented 4 years ago

Thanks @Jimmyson , replacing the URL with

https://www.humblebundle.com/api/v1/trove/chunk?property=popularity&direction=desc&index={idx}

worked for me.

For anyone else, I had to look in python3.8/site-packages/humblebundle_downloader to find download_library.py. That directory for my was inside the lib folder in my virtualenv - if you are installing systemwide that directory will be somewhere else for you.

xtream1101 commented 4 years ago

@Jimmyson Thank you for finding this fix. I have updated the code so the newest version should now work.