search

xtreme8000 / BetterSpades

BetterSpades, an Ace of Spades client targeted at low end systems (GL/ES 1.1). Runs on your grandmother's rig!
https://aos.party/jenkins/job/BetterSpades/
GNU General Public License v3.0
243 stars 40 forks source link

Incorrect ammo and HP counters displayed when spectating someone #162

Closed JimPix1 closed 9 months ago

JimPix1 commented 2 years ago

When you spectate a player in BetterSpades, the ammo and HP indicators are displayed on-screen but are always full/the default even if the person you're spectating does not have full ammo or full HP. Essentially, the indicators are pointless and shouldn't be there. It would be better to remove them while in spectator mode.

dany-on-demand commented 9 months ago

Update on this: ammo is shown correctly, but HP isn't. OpenSpades doesn't show ammo or hp while spectating

image image image image

dany-on-demand commented 9 months ago

Ah, I figured out what the issue is. The issue is that when the player's ammo was spent BEFORE connecting to the server, then if you join internally the client thinks the player has full ammo. If that players shoots/spends ammo or if it's reset by the server (I tested on a tent), then this does get reflected, as in the ammo will be subtracted, but from the starting position of full ammo, so it will still be incorrect. In which case I'd suggest doing the same thing OpenSpades does - simply hiding the ammo/hp. And as Jim pointed out, theoretically players could use this to cheat in for example arena mode (even though I'd say it's quite a stretch). We can keep the code which keeps track of this in spectator. As this is a "bug" in the protocol, this can be fixed later