search

xtrinch / fcm-django-web-demo

Quick demo to demonstrate the use of firebase web push notifications with the use of `javascript` on frontend, `django` on backend and push notifications via `fcm-django` pypi package for django.
74 stars 52 forks source link

http localhost edition with https notes #3

Closed Pymancer closed 7 years ago

Pymancer commented 7 years ago

mostly just README update

xtrinch commented 7 years ago

That looks nearly alright, but instead of a line number in index.html, which will inevitably change at some point and need to be updated, there should be a permalink to the specific commit containing the line, so people still know what the README's talking about.

I would also put django-sslserver in the requirements permanently.

Pymancer commented 7 years ago

Done as advised :)

xtrinch commented 7 years ago

Thank you very much for all the effort! Merging.