Raising the Firebase error instead of returning error 500 in admin

xtrinch / fcm-django

FCM Django: Send push notifications via django to websites, iOS & android mobile devices through FCM (Firebase Cloud Messaging)

http://fcm-django.readthedocs.io/

MIT License

775 stars 196 forks source link

Raising the Firebase error instead of returning error 500 in admin #272

Open p02diada opened 1 month ago

p02diada commented 1 month ago

Hi,

There is a problem from version 2.0.1 with this PR https://github.com/xtrinch/fcm-django/pull/241 in the django Admin. If you try to send test notification to a device that firebase does not accept it raise a 500 error.

xtrinch commented 1 month ago

Yes looks like the admin functions should now be wrapped in a try catch - good find