xtuc / webassemblyjs

Toolchain for WebAssembly
https://webassembly.js.org
MIT License
786 stars 91 forks source link

Integrate TimHambourger/webassemblyjs-wasm-corruption test suite #419

Open xtuc opened 6 years ago

xtuc commented 6 years ago

@TimHambourger made a very useful test harness, we could integrate it in our CI somehow (if @TimHambourger is ok with that).

Note we can keep a seperated repo.

TimHambourger commented 6 years ago

@xtuc Yes! I'm certainly ok with this.

I'm curious how you're imagining this. My first thought would be to make it part of the core repo such that it runs on make test and picks up the local versions of each package. Does Lerna have a notion of a non-publishing package or some such?

Also, thinking through things I like about the current harness:

I don't have a clear point here. Just figured stating those might help define how this harness can fit within the rest of the test suite.

xtuc commented 6 years ago

I would like to avoid adding more wasm binary into this repo and slow down current tests.

I can see two solutions:

FYI you can set private: true in the package.json to avoid Lerna to publish them.

TimHambourger commented 6 years ago

Yes, point well taken about not wanting to slow down current tests. Sure, I'm happy to keep this in my current repository, though I'd want to add you (and others as appropriate) as collaborators. I just don't want to become a bottleneck to changes getting approved.