github-actions[bot]
commented
1 year ago Test results for branch "MUN-155_Refactor_SVDC": https://s3.amazonaws.com/1f-outgoing/munin/MUN-155_Refactor_SVDC/index.html Permanent link for this run: https://s3.amazonaws.com/1f-outgoing/munin/dc0e07f/index.html
The AuditEvent.AddEventForNewJob service deals solely with the first event seen for a Job. All subsequent events are dealt with in the Job.JobInProgress state. As the models evolved the code for handling audit event data was added to both places. As it was largely common, this has now been separated out into the AuditEvent.ProcessAuditEventData function that is called from both other locations.
In addition there were some outstanding ToDos around error handling for the extra job invariant definition. These have now been addressed even though the plan is that SVDC will only ever see valid audit event and audit event data definitions.
SVDC has been built and all tests passed.