xtuml / munin

Apache License 2.0
1 stars 0 forks source link

Mun2 222 review of alarms in unhappy jobs #229

Closed PaulAtAurora closed 3 months ago

PaulAtAurora commented 3 months ago

Colin, Cort,

I think all the changes to address the issue raised by Cort in https://github.com/xtuml/munin/issues/222 have been completed and the build completes successfully.

It would be good for us to do a quick review and walkthrough of the updates together I'm going to propose Monday 17th June at 16:30 BST - hope you can both make it.

One additional topic that we should discuss at that session is whether or not we should make further changes to the UnhappyJob state model - at the moment, the constraint checking (BRANCHCOUNT, LOOPCOUNT, etc.) and invariant checking are effectively bypassed for Unhappy Jobs. Whilst there is no obvious usefulness in doing the constraint checking for Unhappy Jobs it could be argued that it might be useful to perform the invariant checks even in Unhappy Jobs. This was raised with the client but no firm decision to add this functionality back in was made. The state actions to achieve this are all in place but are currently bypassed at run time. Should we leave as is for this release?

Paul

cortlandstarrett commented 3 months ago

We decided on an approach using an attribute that led to a simpler solution.