Open GoogleCodeExporter opened 9 years ago
Original comment by albrecht.andi
on 29 Sep 2011 at 9:30
It looks like the label of the link is wrong/misleading. It actually points to
the next file with comments, but not to the next file with changes.
Original comment by albrecht.andi
on 29 Sep 2011 at 9:32
Thanks for looking at this!
My main observation is this: it slows the review down to iterate through files
with no changes when looking only at the diffs between patch set 1 and patch
set 2.
The way our reviews work is we go through the original changes, we make
comments, the submitter fixes/defends, and updates the issue. We do a second
round reviewing, and wash, rinse, repeat until everything looks good. If we
could streamline subsequent rounds, it would make it less painful to review
changes beyond round 1. Theoretically, we've also already reviewed the changes
from round 1, and generally there are many fewer changes for each round.
So your original analysis for this bug is that the label's wrong. Would you
consider revising that instead that the functionality is wrong? I can file an
RFE if the label is truly in error.
Original comment by ahaw...@basis.com
on 29 Sep 2011 at 4:36
Original comment by albrecht.andi
on 6 Apr 2012 at 6:20
Original issue reported on code.google.com by
ahaw...@basis.com
on 20 Sep 2011 at 4:32