search

xtypebee / rietveld

Automatically exported from code.google.com/p/rietveld
Apache License 2.0
0 stars 0 forks source link

Chat sends notifications for my own rietveld interactions. #401

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I get chat notifications every time I interact with rietveld. These aren't 
really useful since I know what I've done. Given that I interact with rietveld 
quite a bit this can get annoying. Is it possible to make the chat bot only 
notify me when someone else has modified an issue that pertains to me?

Original issue reported on code.google.com by bsalo...@google.com on 31 Oct 2012 at 4:37

GoogleCodeExporter commented 9 years ago 
That's possible. When sending message we can exclude 'me' from the recipients. 
It can be even made optional by adding user preference, but for me it looks 
like a good default behavior.

Original comment by techtonik@gmail.com on 31 Oct 2012 at 7:18

GoogleCodeExporter commented 9 years ago 
Great! Could this rule also apply to emails? It's not quite as bothersome to 
get email updates from my own activity but they also seem unnecessary.

Original comment by bsalo...@google.com on 31 Oct 2012 at 7:27

GoogleCodeExporter commented 9 years ago 
AFAIK the code that sends the message is the same as the one that sends the 
email and it is located in _notify_issue() 
http://code.google.com/p/rietveld/source/browse/codereview/views.py#613

Original comment by techtonik@gmail.com on 31 Oct 2012 at 7:49

GoogleCodeExporter commented 9 years ago 
I am starting to take a look at this.
I can make sure that XMPP messages are not sent to the requester, but for 
emails I already see that there is a safeguard to make sure the original 
requester is not emailed again, I think what you see in your emails is your 
email to the other members of the issue and not an email to yourself.

Original comment by rmis...@google.com on 28 Mar 2013 at 5:52

GoogleCodeExporter commented 9 years ago 
I think you're right. The emails are showing up because skia-review is in the 
CC list.

Original comment by bsalo...@google.com on 28 Mar 2013 at 5:59

GoogleCodeExporter commented 9 years ago 
Started in https://codereview.appspot.com/8099046/

Original comment by rmis...@google.com on 28 Mar 2013 at 6:37

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision 9d5c30b9d19f.

Original comment by techtonik@gmail.com on 30 Mar 2013 at 9:31