Closed GoogleCodeExporter closed 9 years ago
Original comment by john.abd...@gmail.com
on 4 Dec 2012 at 8:31
This appears to be Rietveld's fault. It is replying to /_ah/mail HTTP requests
with 301s trying to force the use of https. I've changed the default version
running on codereview.appspot.com back to version 102, which predates the https
forcing.
Original comment by rsc@golang.org
on 6 Dec 2012 at 6:20
Mail is processed via a http hammer ?!?
/me reaches for a larger hammer.
Original comment by d...@cheney.net
on 6 Dec 2012 at 6:22
rsc: thanks for tracking it down, I thought it was a regression somewhere else
and had https://codereview.appspot.com/6870055/ ready to land.
maruel: in codereview\middleware.py
def process_request(self, request):
if not request.is_secure():
request_url = request.build_absolute_uri(request.get_full_path())
return HttpResponsePermanentRedirect(
request_url.replace('http://', 'https://'))
needs to be updated then to whitelist /_ah/mail?
Original comment by john.abd...@gmail.com
on 6 Dec 2012 at 6:39
I've committed this on trunk at
https://code.google.com/p/rietveld/source/detail?r=bc39c6562b0956adff8c0086a4963
6a6fdc962f5
I don't have access to push updates on the AE instance, so someone with
permission will have to do that.
Original comment by john.abd...@gmail.com
on 10 Dec 2012 at 6:13
Original issue reported on code.google.com by
d...@cheney.net
on 3 Dec 2012 at 7:56