search

xu-cheng / katex-rs

Rust bindings to KaTeX
https://docs.rs/katex
Apache License 2.0
110 stars 11 forks source link

Remove target checks from Cargo.toml. #9

Closed regular-citizen closed 1 year ago

regular-citizen commented 1 year ago

This PR removes the conditional compilation flags in Cargo.toml that mention the target platform.

The reason why this was needed is that it is that, though wasm-bindgen and js-sys issue code that panics when compiled to x64, we want to be able to run cargo check without having to specify the target triple (and both those crates check fine even on x64).

Note that this since these are breaking changes, it would require at least a minor version bump.

xu-cheng commented 1 year ago

Personally, I don't think there is enough justification for this change. You can always run cargo check with specified target. In fact, you have to select corresponding feature anyway. On the other hand, these cfgs help the end users to properly select feature and prevent wrong backend selected.

Anyhow, thanks for the PR.