修改android编译报错

xu-li / cordova-plugin-wechat

A cordova plugin, a JS version of Wechat SDK

1.22k stars 509 forks source link

Closed wangshengjin closed 5 years ago

wangshengjin commented 6 years ago

修改了getAppId获取失败bug 顺便把android-install.js修改了下，android端微信支付会闪退，这个从网上找的的解决办法搞定了

tianjin500w commented 6 years ago

感谢您的修复，确实能编译过去了，不过有个地方我有异议， final String appid = params.getString("appid");

final String savedAppid = getAppId(cordova.getActivity());
final String savedAppid = getAppId(); if (!savedAppid.equals(appid)) { this.saveAppId(cordova.getActivity(), appid); } 这个地方，逻辑上是不是读取保存过的AppId，如果不相同，就保存呢？ getAppId(cordova.getActivity()); 是不是应该改为 getSavedAppId(cordova.getActivity()); ？

wanwanland commented 6 years ago

Could you please merge this?

nevernet commented 6 years ago

i found this pr has been merged, but when the new version will be released?

@xu-li please let me know if we can work together and push a new version to npm.

thank you.

jasonz1987 commented 5 years ago

cordova7 和相关代码已经分开合并提交，谢谢～