xuannianz / EfficientDet

EfficientDet (Scalable and Efficient Object Detection) implementation in Keras and Tensorflow
Apache License 2.0
1.4k stars 395 forks source link

Error in BiFPN output #246

Closed faheem-khaskheli closed 3 years ago

faheem-khaskheli commented 3 years ago

According to Diagram of BiFPN the output of BiFPN is not same as in model.py. In model.py line number 174 and line number 302

return P3_out, P4_td, P5_td, P6_td, P7_out

should be

return P3_out, P4_out, P5_out, P6_out, P7_out

because

P4_td, P5_td, P6_td 

are the output of top-down pathway, but in diagram there is a bottom-up path which is actually the result, so the output should be from the bottom-up path.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.