search

xuantl / open-hardware-monitor

Automatically exported from code.google.com/p/open-hardware-monitor
0 stars 0 forks source link

CPU Fan Speed Is 0 for Winbond W836XX Super I/O #372

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
CPU fan speed shouldn't be 0 from Winbond W836XX Super I/O.  Sometimes, CPU Fan 
speed is 0.

I am using OHM 0.5.1 Beta on Windows 7 64-bit.

Fan speed equation in Section 7.6.1 Fan Speed Management in 
http://71.131.159.28/CA_Manual/GPIO/W83627DHG.pdf didn't evaluate to 0 when 
Count is 0xff.  The documented fan speed equation is RPM = 1.35 x 1000000 / 
(Count x Divisor).

Line 247 in Hardware\LPC\W836XX.cs r382 will assign 0 when count is 0xff.
Here is the code:
float value = (count < 0xff) ? 1.35e6f / (count * divisor) : 0;

If there's no particular reason, please remove assigning 0 as below.
float value = 1.35e6f / (count * divisor);

It doesn't make sense to have 0 speed fan.

Thank you so much.

Original issue reported on code.google.com by LingYM...@gmail.com on 2 Aug 2012 at 9:49

Attachments: