search

xuanxu / starmatrix

Modelling nucleosynthesis of galactic chemical elements
https://starmatrix.readthedocs.io
MIT License
1 stars 3 forks source link

[JOSS Review]: Units #62

Closed CFGrote closed 2 years ago

CFGrote commented 2 years ago

I assume that all quantities are expressed in solar mass units and other domain specific unit systems. It should be mentioned clearly in the code, README and paper.

I could imagine that this code be used as a pre or postprocessor to other codes that may employ a different system of units, so unit conversion would have to be considered. To ease such a use case, I would suggest to employ a physical units library such as pint. I understand this is a huge change to the codebase, therefore I leave this as recommendation for future work.

xuanxu commented 2 years ago

Mentions to the units added to the docs, Readme and paper!

Thanks for the recommendation. We are currently thinking about using astropy.units but at the same time still discussing about if it's worth adding another big dependency...

CFGrote commented 2 years ago

Ok, I'll close here and look forward to units support in 2.0 ;)