search

xueliu / lora-feed

Semtech packages and ChirpStack Network Server stack for OpenWRT
GNU General Public License v2.0
76 stars 55 forks source link

Upstreaming packages #27

Open aparcar opened 2 years ago

aparcar commented 2 years ago

Hi, I'd like to see some of your packages upstream at the official packages.git, would you be interested in collaborating on a migration? Specifically the basicstation should become part of packages.git.

xueliu commented 2 years ago

Hello Aparcar,

Thanks for your comment. I would like also to push the basicstation to the upstream. But the package is a little special as following reasons:

  1. The official basicstation has its own Makefile structure which is very hard to migrate into OpenWRT. So I add personally CMake support for it. Should we use the official basicstation with additional CMake patch or directly use my fork https://github.com/xueliu/basicstation ?
  2. The basicstation supports three different concentrator hardwares (sx1302, sx1308 and sx1301) and three different libraries, respectively. They can be automatically downloaded, of course from my private forks, compiled and linked by CMake. Such scheme is also permitted by OpenWRT ?
  3. Do you have other questions ?
aparcar commented 2 years ago 
1. The official basicstation has its own Makefile structure which is very hard to migrate into OpenWRT. So I add personally CMake support for it. Should we use the official basicstation with additional CMake patch or directly use my fork https://github.com/xueliu/basicstation ?

I've seen the issue and your fixes, I requested upstream for a comment but did not see any reaction as of now.

I'd rather use the official repository and have a single big CMake patch added. Would that work for you?

2. The basicstation supports three different concentrator hardwares (sx1302, sx1308 and sx1301) and three different libraries, respectively. They can be automatically downloaded, of course from my private forks, compiled and linked by CMake. Such scheme is also permitted by OpenWRT ?

I think the download of external libraries within the Makefile is awkward and won't pass the reviewers of packages.git. Would it be possible to add those three packages as well?

3. Do you have other questions ?

For the basistation I'd like to see three variants (using the VARIANT variable) to have all of them build at the same time. An example would be the ucert package.