Give Charset guidance in Files.readLines

xueyin87 / guava-libraries

Automatically exported from code.google.com/p/guava-libraries

Apache License 2.0

0 stars 0 forks source link

Give Charset guidance in Files.readLines #319

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

It has been suggested that Files.readLines should have an overload without a 
Charset. Rather than that (which has problems in terms of which encoding is 
picked by default), this issue is a suggestion that the documentation 
Files.readLines recommends using one of the "easy-access" values in Charsets.

The docs for Charsets should also be expanded to give a very quick lesson as 
to why encodings are necessary, why it's important to pick the right one, and 
some guidance as to what to pick when you genuinely have the choice.

Original issue reported on code.google.com by jonathan.skeet on 29 Jan 2010 at 7:48

GoogleCodeExporter commented 9 years ago

Original comment by kevinb@google.com on 12 Feb 2010 at 5:03

Added labels: Type-Docs

GoogleCodeExporter commented 9 years ago

Original comment by kevinb@google.com on 30 Jul 2010 at 3:50

Added labels: Milestone-Release07

GoogleCodeExporter commented 9 years ago

Original comment by kevinb@google.com on 14 Sep 2010 at 8:55

Added labels: Milestone-Release08
Removed labels: Milestone-Release07

GoogleCodeExporter commented 9 years ago

Original comment by kevinb@google.com on 18 Jan 2011 at 8:35

Added labels: Milestone-Release09

GoogleCodeExporter commented 9 years ago

Original comment by fry@google.com on 26 Jan 2011 at 10:39

Changed state: Accepted

GoogleCodeExporter commented 9 years ago

Original comment by fry@google.com on 24 Mar 2011 at 2:17

Removed labels: Milestone-Release09

GoogleCodeExporter commented 9 years ago

Original comment by kevinb@google.com on 13 Jul 2011 at 6:18

Changed state: Triaged

GoogleCodeExporter commented 9 years ago

Original comment by kevinb@google.com on 16 Jul 2011 at 8:37

Changed state: Accepted

GoogleCodeExporter commented 9 years ago

Original comment by fry@google.com on 10 Dec 2011 at 3:43

Added labels: Package-IO

GoogleCodeExporter commented 9 years ago

Original comment by wasserman.louis on 16 Jan 2012 at 6:56

Added labels: Type-Documentation
Removed labels: Type-Docs

GoogleCodeExporter commented 9 years ago

This might be more appropriate for the wiki than the Javadocs.  (But I don't 
know enough about the subject to do the update myself.)

Original comment by wasserman.louis on 20 Jan 2012 at 5:04

GoogleCodeExporter commented 9 years ago

Original comment by kevinb@google.com on 16 Mar 2012 at 9:32

Added labels: Milestone-Release12

GoogleCodeExporter commented 9 years ago

Kevin, any plans to get this done for r12?

Original comment by cpov...@google.com on 23 Mar 2012 at 8:30

GoogleCodeExporter commented 9 years ago

yup :)

Original comment by kevinb@google.com on 23 Mar 2012 at 11:24

GoogleCodeExporter commented 9 years ago

Original comment by kevinb@google.com on 26 Mar 2012 at 9:40

Changed state: Fixed

GoogleCodeExporter commented 9 years ago

This issue has been migrated to GitHub.

It can be found at https://github.com/google/guava/issues/<id>

Original comment by cgdecker@google.com on 1 Nov 2014 at 4:16

Added labels: MigratedToGitHub

GoogleCodeExporter commented 9 years ago

Original comment by cgdecker@google.com on 3 Nov 2014 at 9:10

Added labels: Restrict-AddIssueComment-Commit