adding an optional currency_map in the config that allow to rename account and commodity

xuhcc / beancount-ethereum-importer

Ethereum transaction importer for Beancount

GNU General Public License v3.0

12 stars 5 forks source link

adding an optional currency_map in the config that allow to rename account and commodity #4

Closed grostim closed 2 years ago

grostim commented 2 years ago

Hi this PR is a proposal to solve two issue i have met on alternate blockchain:

On Avalanche, bridged token have a dot in their name (for example: USDC.e) which is a problem as account can't have a dot in their name.
Also i have some token on XDAI whose name is 20 character long, which is not accepted in beancount.

Thanks to the additional mapping in the config file, i am now able to rename the account suffix and/or the commodity.

grostim commented 2 years ago

It is probably not the prettiest code, but the additional commit should comply with your proposal.

xuhcc commented 2 years ago

Thanks. Do you want to keep the debug method?

xuhcc commented 2 years ago

I'd remove these statements. Python has a logging module in its standard library if you want to print debug info. But I think adding logging is out of scope of this pull request.

grostim commented 2 years ago

No the debug method was mainly to troubleshooting. It may be removed. No problem.