Minor build issues on Debian bookworm

xuhuisheng / rocm-build

build scripts for ROCm

Apache License 2.0

181 stars 35 forks source link

Minor build issues on Debian bookworm #24

Closed kroll-j closed 1 year ago

kroll-j commented 2 years ago

Environment

Hardware	description
GPU	gfx803
CPU	ryzen7

Software	version
OS	debian bookworm
ROCm	4.3
Python	3.9.9
Linux	5.15.0-1-amd64
cmake	3.22.1

I'm currently trying to build rocm 4.5 for gfx803 using your feature/build branch. If I run into any more minor issues I'll report them here, instead of opening a new issue for every little thing.

BTW, thanks for your awesome work with the build scripts and especially support for the gfx803.

kroll-j commented 2 years ago

34.miopen.sh, half include dir

After adding -DHALF_INCLUDE_DIR=$ROCM_GIT_DIR/half/include the build script seems to work:

diff --git a/34.miopen.sh b/34.miopen.sh
index a78a069..55aa2dc 100644
--- a/34.miopen.sh
+++ b/34.miopen.sh
@@ -17,6 +17,7 @@ CXX=$ROCM_INSTALL_DIR/llvm/bin/clang++ cmake \
     -DCPACK_SET_DESTDIR=OFF \
     -DCPACK_PACKAGING_INSTALL_PREFIX=$ROCM_INSTALL_DIR \
     -DCMAKE_INSTALL_PREFIX=$ROCM_INSTALL_DIR \
+    -DHALF_INCLUDE_DIR=$ROCM_GIT_DIR/half/include \
     -G Ninja \
     $ROCM_GIT_DIR/MIOpen
 ninja

xuhuisheng commented 2 years ago

I think we could move half before the miopen, so the dependency issue could be resolved.

BTW: on ROCm-4.5, the only issue is rocBLAS, we didn't need to rebuild whole ROCm components, please refe here : https://github.com/xuhuisheng/rocm-gfx803

And I had test rocm-build on ubuntu-21.04 daily-build which using kernel-5.13. There are some compiling issues on ther next LTS version. Maybe I can create a branch for it.

xuhuisheng commented 1 year ago

I will close this issue, if you still meet the problem, please reopen it.