search

xuhuisheng / rocm-build

build scripts for ROCm
Apache License 2.0
181 stars 35 forks source link

How to Get This Working On An 18.04 Based System? #25

Closed BloodyMess closed 2 years ago

BloodyMess commented 2 years ago

I'm trying it on 18.04 now.

One thing I've run into is that the scripts don't gracefully handle paths with spaces in the name. The variables need to be enclosed in double quotes when they are used in the scripts.

For instance lines 5 & 6 of 00.rocm-core.sh need to be like this:

mkdir -p "$ROCM_BUILD_DIR/rocm-core"
cd "$ROCM_BUILD_DIR/rocm-core"

There's probably more places besides those first few lines in the other scripts. I'm going through them now.

Also, I've created a convenience script to go through the scripts and execute them in order so I don't have to do it manually.

BloodyMess commented 2 years ago

Well, I've run into a couple of problems in the scripts: 1) All those instances of sudo apt install for various packages aren't OK. It's really bad to just haul off and install system-wide packages on your own. They really need to be removed, and the packages they install added to a list of dependencies/prerequisites in the readme file so the user can decide for themselves how to go about handling those things.

2) It turns out that you do have a hard dependency on 20.04 in the form of installing python-is-python3. I already have the symlink that that package creates, so I've just disabled it along with all the other instances of sudo apt install.

xuhuisheng commented 2 years ago

I had move sudo apt install from each of shells to a single install-dependency.sh.

And python-is-pyhon3 need by repo on ubuntu-20.04, you can remove it on other version of ubuntu.

xuhuisheng commented 2 years ago

I will close this issue, if you still meet the problem, please reopen it.