search

xuhuisheng / rocm-gfx803

185 stars 9 forks source link

Update blender? #28

Closed redthing1 closed 1 year ago

redthing1 commented 1 year ago

Hello,

Could you release an updated blender build please?

xuhuisheng commented 1 year ago

Which version of blender do you want?

redthing1 commented 1 year ago

One of the 3.4.x please; the reason is because blender made breaking changes to their format in 3.4. So your 3.3 build works great, but can't open my 3.4 files. Would be awesome if you could build it. Thanks 🙏

On Thu, Mar 23, 2023, 16:14 Xu Huisheng @.***> wrote:

Which version of blender do you want?

— Reply to this email directly, view it on GitHub https://github.com/xuhuisheng/rocm-gfx803/issues/28#issuecomment-1482031443, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM6626QAHIGABAPURWKGJ7LW5TKNLANCNFSM6AAAAAAWF2WQAQ . You are receiving this because you authored the thread.Message ID: @.***>

redthing1 commented 1 year ago

3.4.1

xuhuisheng commented 1 year ago

I may get a try on this weekend.

One of the 3.4.x please; the reason is because blender made breaking changes to their format in 3.4. So your 3.3 build works great, but can't open my 3.4 files. Would be awesome if you could build it. Thanks 🙏 … On Thu, Mar 23, 2023, 16:14 Xu Huisheng @.> wrote: Which version of blender do you want? — Reply to this email directly, view it on GitHub <#28 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM6626QAHIGABAPURWKGJ7LW5TKNLANCNFSM6AAAAAAWF2WQAQ . You are receiving this because you authored the thread.Message ID: @.>

redthing1 commented 1 year ago

Thank you, let me know.

xuhuisheng commented 1 year ago

@redthing1 I rebuilt blender-3.4.1 for gfx803, The cube demo just fine. You can have a try.

https://github.com/xuhuisheng/rocm-gfx803/releases/download/rocm541/blender-3.4.1-ubuntu2004-gfx803.tar.gz

And here is some screenshot for blender-3.4.1. https://github.com/xuhuisheng/rocm-gfx803/blob/master/blender.md#blender-341-and-rocm-541

redthing1 commented 1 year ago

Awesome, thank you so much. I will try it

redthing1 commented 1 year ago

I tried it: It works great! Can you post a source archive please? And just briefly explain what you had to change.

xuhuisheng commented 1 year ago

@redthing1 The source of blender is too big to upload.

My modification is very simple, please read this markdown. Although it is for blender-3.3 and ROCm-5.3, I just do same patch on blender-3.4 with ROCm-5.4.1.

https://github.com/xuhuisheng/rocm-gfx803/blob/master/blender.md

  1. modify intern/cycles/kernel/device/hip/compat.h, change all of __noinline__ to __inline__
  2. modify intern/cycles/device/hip/util.h, change 9 to 8, then cycles can use gfx803.

Then you could re-compile the hip kernel by yourself

/opt/rocm/bin/hipcc -Wno-parentheses-equality -Wno-unused-value \
  -O3 -ggdb -save-temps --amdgpu-target=gfx803 \
  -I /home/work/blender-git/blender/intern/cycles \
  --genco /home/work/blender-git/blender/intern/cycles/kernel/device/hip/kernel.cpp \
  -o "/home/work/blender-git/build_linux_cycles/bin/lib/kernel_gfx803.fatbin"

Finally we got the kernel fatbin file, put it to the related directory, like YOUR_BLENDER_34_DIR/3.4/scripts/addons/cycles/lib/kernel_gfx803.fatbin. restart blender, it will use our customized kernel next time.

redthing1 commented 1 year ago

Thank you very much. I had tried and failed in the past, this method seems to make Blender work 100% great on my RX580 ROCm. Thank you again.

On Mon, Mar 27, 2023, 01:18 Xu Huisheng @.***> wrote:

@redthing1 https://github.com/redthing1 The source of blender is too big to upload.

My modification is very simple, please read this markdown. Although it is for blender-3.3 and ROCm-5.3, I just do same patch on blender-3.4 with ROCm-5.4.1.

https://github.com/xuhuisheng/rocm-gfx803/blob/master/blender.md

  1. modify intern/cycles/kernel/device/hip/compat.h, change all of noinline to inline
  2. modify intern/cycles/device/hip/util.h, change 9 to 8, then cycles can use gfx803.

Then you could re-compile the hip kernel by yourself

/opt/rocm/bin/hipcc -Wno-parentheses-equality -Wno-unused-value \ -O3 -ggdb -save-temps --amdgpu-target=gfx803 \ -I /home/work/blender-git/blender/intern/cycles \ --genco /home/work/blender-git/blender/intern/cycles/kernel/device/hip/kernel.cpp \ -o "/home/work/blender-git/build_linux_cycles/bin/lib/kernel_gfx803.fatbin"

Finally we got the kernel fatbin file, put it to the related directory, like YOUR_BLENDER_34_DIR/3.4/scripts/addons/cycles/lib/kernel_gfx803.fatbin. restart blender, it will use our customized kernel next time.

— Reply to this email directly, view it on GitHub https://github.com/xuhuisheng/rocm-gfx803/issues/28#issuecomment-1484707313, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM6626UU4VYBVT6S74QRYZDW6FENNANCNFSM6AAAAAAWF2WQAQ . You are receiving this because you were mentioned.Message ID: @.***>