search

xulion / scope4code

cscope support for visual studio code
MIT License
21 stars 8 forks source link

Fix cscope command line #45

Closed sysoleg closed 4 years ago

sysoleg commented 4 years ago

In order to use and to prevent removal or unnecessary rebuilding of cscope inverted index files (cscope.in.out and cscope.po.out), the options (-k, -q) for index building and search commands must be consistent.

xulion commented 4 years ago

Oleg,

Thanks for the pull request. It’s intended to have the default settings. You shall be able to customize the command with vscode setting.

sysoleg commented 4 years ago

Yes, of course. But I think it is better to have symmetry in cscope options by default. Index files are unconditionally rebuilding during the first find (-L0,1,2,3,4) with current defaults and performs slower afterwards because of the absence of -q option in find commands. This behavior is very visible with huge codebases where cscope index setup takes a few minutes, such as Linux Kernel source code.

xulion commented 4 years ago

I see. Thanks. Will merge and publish with another security patch together