xulunfan / memcached-session-manager

Automatically exported from code.google.com/p/memcached-session-manager
0 stars 0 forks source link

it is not necessay to loadFromMemcached in createSession #122

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
I don't understand, loadFromMemcached has bean invoked in findSession methed. 
why we still invoked loadFromMemcached in createSession.

if we need invoked createSession,it explain the sessionId is not in memcached.
so it is not necessay to load the session From Memcached in createSession.

Original issue reported on code.google.com by anran.gu...@gmail.com on 22 Feb 2012 at 10:20

GoogleCodeExporter commented 9 years ago
This was implemented similarly in a previous version of tomcats 
PersistentManager (which I used as blueprint together with DeltaManager when I 
started this project), but AFAICS you're right, that the invocation of 
loadFromMemcached from createSession can be omitted, as all createSession 
invocations before also invoke findSession (checked with current 
tomcat6/tomcat7 versions).

Thanx for spotting this!

Original comment by martin.grotzke on 22 Feb 2012 at 1:11

GoogleCodeExporter commented 9 years ago
Changed.

Original comment by martin.grotzke on 4 Mar 2012 at 12:15