search

xunhuang / covid-19

MIT License
17 stars 16 forks source link

Add slider to map for confirmed cases #114

Closed tumbleshack closed 4 years ago

tumbleshack commented 4 years ago

Two notes:

  1. Should we use sticky state? Pro: Users can navigate between their state and US to see how their state compared to the US on a given day. Con: Next time they visit the site, they'll be looking at a map that's x days old.
  2. How do you like the current method of displaying the current map's date?

Closes #102 (I think)

tumbleshack commented 4 years ago

Oh, a third note: I have the start date hardcoded as 04/01 as your comment did, should we look for the first date with data like we do with the graph?

xunhuang commented 4 years ago

by and large the change looks good. perf was great also. very happy that you hide the slider for other tabs before they are implemented.

But why stop at -30 days?

xunhuang commented 4 years ago

haven't checked on mobile, either 5/1 or just Date would be fine for the label. we can change that easily. If there is time, I would rather it being spent on getting New, Death, Growth working. We can finess the GUI over time.

tumbleshack commented 4 years ago

Made date label and oldest date changes! I agree about the New, Death, Growth. I can look into this, though it may take longer. Not as familiar with the data side.