search

xunhuang / covid-19

MIT License
17 stars 16 forks source link

Add a nearby view to the world stuff #116

Closed aschleck closed 4 years ago

aschleck commented 4 years ago

From our previously discussed tasks:

P0 - data generation automated and cleaned up. is this done? not sure how it works P0 - US bridging code (done) P1 (P0 for ads) - geoIP --> country not done P2 - search bar not done

P0 - Fix log scale (done) P0 - sort the data tables (done) P0(?) - pull in the comments not done P0 - pull in the footer (done) P0 - figure out if we really want the thing to say "Earth", it feels dorky but I didn't know what else to put. "World" doesn't sound right to me. (I guess this is done) P? pull in the social media icons (done) P? add per capita in the table (done) P? adds days 2x to the table (done) P? decide if we want to show these numbers, and if so how (we don't want to because we don't have the data)

Can you think of more? I guess: P0 - determine the canonical graphs to show not done P0 - accept that we aren't launching with maps? Unless you want to figure out the geography stuff with RSM, I'd rather not

xunhuang commented 4 years ago

P0 - data generation automated and cleaned up. is this done? not sure how it works

I guess this is done. I'll make it build along with the other stuff (npm run data). Will remove world.json file from source tree though.

P1 (P0 for ads) - geoIP --> country not done [ this we will need to figure out how to map to a country from current APIs] P2 - search bar not done

P0(?) - pull in the comments not done [ we can just use the existing one right?]

P? decide if we want to show these numbers, and if so how (we don't want to because we don't have the data)

we should have this last one, from JHU data, we have confirmed, death, active and recovery from most places, right? I have seen people taking screenshots of these high level numbers everywhere.

On Fri, May 8, 2020 at 2:10 PM April Schleck notifications@github.com wrote:

From our previously discussed tasks:

P0 - data generation automated and cleaned up. is this done? not sure how it works P0 - US bridging code (done) P1 (P0 for ads) - geoIP --> country not done P2 - search bar not done

P0 - Fix log scale (done) P0 - sort the data tables (done) P0(?) - pull in the comments not done P0 - pull in the footer (done) P0 - figure out if we really want the thing to say "Earth", it feels dorky but I didn't know what else to put. "World" doesn't sound right to me. (I guess this is done) P? pull in the social media icons (done) P? add per capita in the table (done) P? adds days 2x to the table (done) P? decide if we want to show these numbers, and if so how (we don't want to because we don't have the data)

https://user-images.githubusercontent.com/115766/80943007-0c0f5480-8d9b-11ea-978a-6da6d3ef6c76.png

Can you think of more? I guess: P0 - determine the canonical graphs to show not done P0 - accept that we aren't launching with maps? Unless you want to figure out the geography stuff with RSM, I'd rather not

You can view, comment on, or merge this pull request online at:

https://github.com/xunhuang/covid-19/pull/116 Commit Summary

  • Add a nearby view to the world stuff.

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/xunhuang/covid-19/pull/116, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFSGFZP7EBFI5Q6A6BC3O3RQRYMVANCNFSM4M4O6HYA .