search

xunhuang / covid-19

MIT License
17 stars 16 forks source link

Add a search box and a bunch of other nonsense #117

Closed aschleck closed 4 years ago

aschleck commented 4 years ago

image image

xunhuang commented 4 years ago

This is lovely. Question: do you prefer to launch as soon as we put in the geo stuff, or do you want to make it more perfect. :)

There will always be feature catchup, not sure if we will be feature In-parity. Examples:

Really up to you. I’d be supportive of what you decide.

April Schleck notifications@github.com於 2020年5月8日 週五，下午11:43寫道：

  • search box
  • highlighted the additional numbers you suggested in the top bar
  • tweak the graphs into something more useful
  • fixed the mobile layout

[image: image] https://user-images.githubusercontent.com/115766/81466297-69354c80-9185-11ea-8ce8-f3eace7ae09c.png [image: image] https://user-images.githubusercontent.com/115766/81466337-b2859c00-9185-11ea-9545-7bf4ec52246c.png

You can view, comment on, or merge this pull request online at:

https://github.com/xunhuang/covid-19/pull/117 Commit Summary

  • Add a search box, tweak the graphs, fix the mobile layout, and probably some other nonsense.

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/xunhuang/covid-19/pull/117, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFSGF5CTYM2K4NRIBVWHIDRQT3SDANCNFSM4M4VOWLQ .

aschleck commented 4 years ago

Ahhhh too much responsibility :)

I guess launching earlier is better than launching later. I have 0 motivation to touch maps, so definitely happy to not wait for that. I do have an aspirational goal to enable comparing places on the same graph, but that might take me a long time so waiting for it would probably be a mistake.

By the way I looked around for geo location stuff, have you tried https://ip-api.com/? No idea if it's good, but it's apparently completely free for non-profit. I don't have the API keys for the geo IPs and some of the stuff makes me nervous (API key #1, API key #2, API key #3...) and makes me want to not touch it. So not sure how much work I can do on integrating that stuff. But the good/bad news with country data is it's really rare to have anything other than country level, so just taking the country code from ipdata or ip-api or whatever is probably perfect. I was planning on putting a crosshair icon (equivalent to "Find My Location") into the right side of the search box at some point, but that doesn't seem like much of a blocker.

Projections would be fun and I did some thinking about how to support the envelope in the UI. I don't really want to write the code to compute them though (I guess that would go into world_data_gen.js?) I think if you or someone else wanted to tackle computing them it'd be worth waiting for it, but otherwise I feel pretty meh.

Other things missing relative the main site:

Anyway yeah, I guess let's do the geo stuff and see how it goes?

aschleck commented 4 years ago

Oh of course metros are missing too. But we have so little detailed country data that there's no point in metros outside the US

And links to public health departments are missing

xunhuang commented 4 years ago

hey, lets move this conversation to a github issue instead. the PR keeps closing. :)

On Sat, May 9, 2020 at 1:17 AM April Schleck notifications@github.com wrote:

Oh of course metros are missing too. But we have so little detailed country data that there's no point in metros outside the US

And links to public health departments are missing

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/xunhuang/covid-19/pull/117#issuecomment-626127311, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFSGF3QHJ4AN7RV7Z2CMLDRQUGRFANCNFSM4M4VOWLQ .

xunhuang commented 4 years ago

https://github.com/xunhuang/covid-19/issues/121

On Sat, May 9, 2020 at 10:52 AM Xun Wilson Huang xhuang@gmail.com wrote:

hey, lets move this conversation to a github issue instead. the PR keeps closing. :)

On Sat, May 9, 2020 at 1:17 AM April Schleck notifications@github.com wrote:

Oh of course metros are missing too. But we have so little detailed country data that there's no point in metros outside the US

And links to public health departments are missing

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/xunhuang/covid-19/pull/117#issuecomment-626127311, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFSGF3QHJ4AN7RV7Z2CMLDRQUGRFANCNFSM4M4VOWLQ .