search

xunhuang / covid-19

MIT License
17 stars 16 forks source link

Minor cleanup of random things #73

Closed aschleck closed 4 years ago

aschleck commented 4 years ago

I'm in the market for something fun other than feature tweaking, let me know if you have something in mind :)

Some things on my mind:

xunhuang commented 4 years ago

move ./data/AllData.json and ./data/county_gps.json into public to be fetched rather than directly embedded in the JS bundle (would moving these mess up your pipelines? do I just update normalize_data.js?)

if you run normalize_data.js and change where the file goes, and read them back it's going to be ok. I think. That said, perf wise, is fetching from the public that different from being in the bundle since the app really needs the file to run anyways. I don't have big objection, tiny concerned that the two step will serialized (load the bundle, execute the bundle, then fetch). However, one benefit is once the file is in the public html, we can point whoever that wants to use it to download it, instead of directing them to github.

move files into organized directories

Feel free!

seeing what can be done about MyRoutes and the history stuff in MyTabs

That is a mess. And I want introduce a third level tab, like those in the Map. would be great to have them work out the history stuff too.

playing around with those UI mocks? probably a bad idea

I think overall, we should think about how we should structure the UX. As it, things are getting very crowded and I'm out of my depth on how to organize things. Since you seem to have sharp clarity of organization, feel free to take a stab at it. I have 3 or 4 more graphs/map that I want to stick it in there somehow. :)

Lastly thank you for your help on this! Other than myself, you have contributed to most to the project thus far, by far! it's our project now (not just mine.) I'll add you as an admin to the firebase project.

aschleck commented 4 years ago

Wow thank you for such kind feedback! I am excited to join the Firebase project and see the hospitals tab finally load on my computer :D

I will see what I can come up with for those other proposals. I really admire how far (and successfully) you've been pushing this project, it's nice to work with you!

xunhuang commented 4 years ago

I'm like a jack of all trades but master of none. I used to be a startup guy but in virtualization technology (10+ years ago) but got suckered in management along the way. Now I'm trying things out in consumer space, don't really know anything, but willing to learn and try things out. While I haven't learned much technical things at Facebook in my pointy-hair management/sr engineer role, I appreciate the move fast and break things culture. After all, life won't be lost if the dashboard is down/slightly inaccurate, so why not run fast. I know I'm sloppy, but you should have seen the code before I finally buckled down and came up with data layer with AllData.json. Before, all the shitting logic in normalize_data.js was in the frontend code, I was literally getting dizzy trying fix all the data error in the UI code. If I didn't rewrite at least that part before you showed up, you would probably take a peak and say "shit code, I won't touch that." At least now it's structurally sound, piecemeal bad :)

On Sun, Apr 12, 2020 at 12:15 AM April Schleck notifications@github.com wrote:

Wow thank you for such kind feedback! I am excited to join the Firebase project and see the hospitals tab finally load on my computer :D

I will see what I can come up with for those other proposals. I really admire how far (and successfully) you've been pushing this project, it's nice to work with you!

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/xunhuang/covid-19/pull/73#issuecomment-612574879, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFSGFZ7QOMI2SHBFRIXEF3RMFTCVANCNFSM4MGJBWXA .