xunhuang / covid-19

MIT License
17 stars 16 forks source link

Create footer for github, fb, data, etc. #85

Closed tumbleshack closed 4 years ago

tumbleshack commented 4 years ago

As per discussion in #3 , creating footer to contain:

  1. Link to Github + FB working group
  2. Term of service (disclaimer on data)
  3. FAQ
  4. Data Credits
  5. Credits for people that contributed to this project
  6. Data download links.
tumbleshack commented 4 years ago

Read before landing

To get the Google Sheet pull working, the owner of the spreadsheet must:

Note that:

This version of the Google Sheets API has a limit of 500 requests per 100 seconds per project, and 100 requests per 100 seconds per user. Limits for reads and writes are tracked separately. There is no daily usage limit.

These instructions come from the package's readme

xunhuang commented 4 years ago

I think you misunderstood my point of the google sheet. I was going to pull the sheet from the build process so it's bundled in instead of having each page load to fetch from the googlesheet.

it is here now website/src/data/contributors.json

sorry for the unclear communciation.

data credit is at : website/src/graphs/DataCredit.js

Also, can you get your pull request into a state where squash and merge? currently its show as work in progress.

image

Thanks for all your effort!

tumbleshack commented 4 years ago

Haha, that does make much more sense! Thanks. I'll change that

tumbleshack commented 4 years ago

You should be able to review it now.

xunhuang commented 4 years ago

looks good over all, can you please make the following change?

image can you please the link show the popup for this website/src/data/contributors.json instead?

xunhuang commented 4 years ago

you probably need to rebase to see this file

image

tumbleshack commented 4 years ago

Okay, not sure what's going one with this PR. Gonna close it and re-open. New one looks better: #93

@xunhuang Thanks, I was working on those changes as you were reviewing them actually