Closed tumbleshack closed 4 years ago
To get the Google Sheet pull working, the owner of the spreadsheet must:
Contributer
(case sensitive)Enable APIs and Services
and search for Google Sheets
. Google Sheets API
will show up as the sole result. Click on it.Enable
.Credentials
on the left sidebar. Click on it. Then, click on Create Credentials
> API Key
(you may have to refresh for this option to become visible).API key created
with the API key. This is your API key.https://docs.google.com/spreadsheets/d/[THIS-IS-THE-DOC-ID]/
.env
file in the root of the project with following contents:
REACT_APP_GOOGLE_SHEETS_API_KEY=[YOUR-API-KEY]
REACT_APP_GOOGLE_SHEETS_DOC_ID=[YOUR-DOC-ID]
Note that:
This version of the Google Sheets API has a limit of 500 requests per 100 seconds per project, and 100 requests per 100 seconds per user. Limits for reads and writes are tracked separately. There is no daily usage limit.
These instructions come from the package's readme
I think you misunderstood my point of the google sheet. I was going to pull the sheet from the build process so it's bundled in instead of having each page load to fetch from the googlesheet.
it is here now website/src/data/contributors.json
sorry for the unclear communciation.
data credit is at : website/src/graphs/DataCredit.js
Also, can you get your pull request into a state where squash and merge? currently its show as work in progress.
Thanks for all your effort!
Haha, that does make much more sense! Thanks. I'll change that
You should be able to review it now.
looks good over all, can you please make the following change?
can you please the link show the popup for this website/src/data/contributors.json instead?
you probably need to rebase to see this file
Okay, not sure what's going one with this PR. Gonna close it and re-open. New one looks better: #93
@xunhuang Thanks, I was working on those changes as you were reviewing them actually
As per discussion in #3 , creating footer to contain: